Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guild.owner_id type mismatch between docs and code #1273

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

nerd-bear
Copy link
Contributor

@nerd-bear nerd-bear commented Jan 17, 2025

Summary

Guild.owner_id documented as int, but is Optional[int] in code. Here are the links:
https://docs.disnake.dev/en/stable/api/guilds.html#disnake.Guild.owner_id
disnake/disnake/guild.py
disnake/disnake/guild.py

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Signed-off-by: Nerd Bear <nerd.bear.dev@gmail.com>
@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples skip news labels Jan 17, 2025
disnake/guild.py Outdated Show resolved Hide resolved
disnake/guild.py Show resolved Hide resolved
nerd-bear and others added 2 commits February 2, 2025 21:05
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Nerd Bear <nerd.bear.dev@gmail.com>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Nerd Bear <nerd.bear.dev@gmail.com>
@nerd-bear nerd-bear requested a review from shiftinv February 5, 2025 08:15
@shiftinv shiftinv enabled auto-merge (squash) February 5, 2025 12:16
@shiftinv shiftinv added this to the disnake v2.11 milestone Feb 5, 2025
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit a72a457 into DisnakeDev:master Feb 5, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants